- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.4k
Backport(v1.16): ci: remove reference to mock object after test (#5055) #5086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
      
        
          +9
        
        
          −1
        
        
          
        
      
    
  
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    Watson1978
  
              
              previously approved these changes
              
                  
                    Sep 11, 2025 
                  
              
              
            
            
| This should fix  | 
**Which issue(s) this PR fixes**: Fixes fluent#5054 **What this PR does / why we need it**: This PR will resolve CI error. **Docs Changes**: N/A **Release Note**: N/A --------- Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
e3c9792    to
    de93fa1      
    Compare
  
    | On v1.16 branch, seems it still causes #5054 with   | 
| Seems the error is caused by fluentd/test/plugin/test_out_forward.rb Line 347 in 57d3738 
 On master branch,  | 
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
              
                    Watson1978
  
              
              reviewed
              
                  
                    Sep 11, 2025 
                  
              
              
            
            
              
                    Watson1978
  
              
              approved these changes
              
                  
                    Sep 11, 2025 
                  
              
              
            
            
| Thanks for fixing it! | 
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Which issue(s) this PR fixes:
Fixes #5054
What this PR does / why we need it:
This PR will resolve CI error.
Docs Changes:
N/A
Release Note:
N/A